fix(Container): Fix unmapped components silently do nothing #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By doing console.warn when a child has a cqType not mapped to a component. Thus helping developers to analyze scenarios where a component is not rendered.
|
@samuelgomezvaltech - I was looking for something like this a while back and endedup writing a wrapper component that does the check for me. However I suggest a small change. Please add the warnings only when it is inEditor, this way there is no need for end users to be aware of this behavior. See if this makes sense. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing console.warn when a child has a cqType not mapped to a component.
Description
console.warn when componentMapping.get(cqType here) finds no component mapped to that cqType.
Related Issue
#87
Motivation and Context
Thus helping developers to analyze scenarios where a component is not rendered.
The provided message is specific enough to help both when the cause of the issue is a missing/typo'ed MapTo and when is not (no rendering && not this message --> mapping is ok --> focus on other possible causes).
How Has This Been Tested?
Unit test is provided. Node.js version used was v14.17.3. No higher since that would bump the package-lock.json lockfileVersion.
Screenshots (if appropriate):
Resulting warning message in the console:
Types of changes
Checklist: